[llvm-commits] [llvm] r131581 - in /llvm/trunk: include/llvm/DefaultPasses.h include/llvm/Support/StandardPasses.h lib/Support/StandardPasses.cpp

[Chris Lattner]

On May 21, 2011, at 12:18 PM, Chris Lattner wrote:

>>> 
>>> Are you ok with reverting the patch and trying a different approach?
>> 
>> I'd rather not revert it, since I'm using this functionality, but I've no problem with replacing it with something better - as far as I'm concerned the design is not finalised until 3.0 ships, and I'm happy to make changes to it, including significant architectural changes, as long as we end up with something useable at the end.  
> 
> I understand your position here, but my problem is that this patch should never have gone in in the first place.  One bad part of post-commit review is that sometimes stuff like this is caught late.  Are you ok with reverting it and doing the right thing?  I want to make it really clear that I agree with your goals, just not this implementation approach.

How about this:

1. I'll implement the new builder class into a new file, which will have the same functionality as before.
2. Revert your patch.
3. You can add the functionality you need to the new builder.

This gets us to the right position, without requiring your to redesign the whole thing.  Seem reasonable?

-Chris