[llvm-commits] [poolalloc] r131570 - in /poolalloc/trunk/lib/AssistDS: GEPExprArgs.cpp LoadArgs.cpp

Arushi Aggarwal aggarwa4 at illinois.edu
Wed May 18 13:52:42 PDT 2011


Author: aggarwa4
Date: Wed May 18 15:52:42 2011
New Revision: 131570

URL: http://llvm.org/viewvc/llvm-project?rev=131570&view=rev
Log:
Minor comments.

Modified:
    poolalloc/trunk/lib/AssistDS/GEPExprArgs.cpp
    poolalloc/trunk/lib/AssistDS/LoadArgs.cpp

Modified: poolalloc/trunk/lib/AssistDS/GEPExprArgs.cpp
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/lib/AssistDS/GEPExprArgs.cpp?rev=131570&r1=131569&r2=131570&view=diff
==============================================================================
--- poolalloc/trunk/lib/AssistDS/GEPExprArgs.cpp (original)
+++ poolalloc/trunk/lib/AssistDS/GEPExprArgs.cpp Wed May 18 15:52:42 2011
@@ -131,7 +131,6 @@
               0, F->getAttributes().getRetAttributes()));
           NewF->setAttributes(NewF->getAttributes().addAttr(
               ~0, F->getAttributes().getFnAttributes()));
-          //NewF->setAlignment(F->getAlignment());
           //Get the point to insert the GEP instr.
           SmallVector<Value*, 8> Ops(CI->op_begin()+1, CI->op_end());
           Instruction *InsertPoint;

Modified: poolalloc/trunk/lib/AssistDS/LoadArgs.cpp
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/lib/AssistDS/LoadArgs.cpp?rev=131570&r1=131569&r2=131570&view=diff
==============================================================================
--- poolalloc/trunk/lib/AssistDS/LoadArgs.cpp (original)
+++ poolalloc/trunk/lib/AssistDS/LoadArgs.cpp Wed May 18 15:52:42 2011
@@ -60,7 +60,7 @@
 
           if(CI->hasByValArgument())
             continue;
-          // if the GEP calls a function, that is externally defined,
+          // if the CallInst calls a function, that is externally defined,
           // or might be changed, ignore this call site.
           Function *F = CI->getCalledFunction();
 
@@ -75,6 +75,7 @@
           Function::arg_iterator ai = F->arg_begin(), ae = F->arg_end();
           unsigned argNum = 1;
           for(; argNum < CI->getNumOperands();argNum++, ++ai) {
+            // do not care about dead arguments
             if(ai->use_empty())
               continue;
             if(F->paramHasAttr(argNum, Attribute::SExt) ||





More information about the llvm-commits mailing list