[llvm-commits] [llvm] r131502 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

[Jim Grosbach]

Hey Eli,

There's some buildbot fallout that looks like it may be related to this. ( http://google1.osuosl.org:8011/builders/llvm-gcc-native-mingw32-win7/builds/1933)

At first impression, the tests may just need updated to deal with the improved handling. Can you have a look?

-Jim

On May 17, 2011, at 4:02 PM, Eli Friedman wrote:

> Author: efriedma
> Date: Tue May 17 18:02:10 2011
> New Revision: 131502
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=131502&view=rev
> Log:
> Make fast-isel miss counting in -stats and -fast-isel-verbose take terminators into account; since there are many fewer isel misses with recent changes, misses caused by terminators are more significant.
> 
> 
> Modified:
>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp?rev=131502&r1=131501&r2=131502&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp Tue May 17 18:02:10 2011
> @@ -972,9 +972,14 @@
>           continue;
>         }
> 
> -        // Otherwise, give up on FastISel for the rest of the block.
> -        // For now, be a little lenient about non-branch terminators.
> -        if (!isa<TerminatorInst>(Inst) || isa<BranchInst>(Inst)) {
> +        if (isa<TerminatorInst>(Inst) && !isa<BranchInst>(Inst)) {
> +          // Don't abort, and use a different message for terminator misses.
> +          ++NumFastIselFailures;
> +          if (EnableFastISelVerbose || EnableFastISelAbort) {
> +            dbgs() << "FastISel missed terminator: ";
> +            Inst->dump();
> +          }
> +        } else {
>           ++NumFastIselFailures;
>           if (EnableFastISelVerbose || EnableFastISelAbort) {
>             dbgs() << "FastISel miss: ";
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits