[llvm-commits] [llvm] r131516 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCalls.cpp lib/Transforms/InstCombine/InstructionCombining.cpp test/Transforms/InstCombine/call.ll

[Chris Lattner]

On May 17, 2011, at 6:28 PM, Eli Friedman wrote:

> Author: efriedma
> Date: Tue May 17 20:28:27 2011
> New Revision: 131516
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=131516&view=rev
> Log:
> Start trying to make InstCombine preserve more debug info.  The idea here is to set the debug location on the IRBuilder, which will be then right location in most cases.  This should magically give many transformations debug locations, and fixing places which are missing a debug location will usually just means changing the code creating it to use the IRBuilder.
> 
> As an example, the change to InstCombineCalls catches a common case where a call to a bitcast of a function is rewritten.
> 
> Chris, does this approach look reasonable?

Yep, this is a great approach for InstCombine, thanks Eli.

Incidentally, Devang, we really shouldn't have to sprinkle setDebugLoc() through to a zillion different other transformations.  Maybe they should start migrating to IRBuilder.

-Chris