[llvm-commits] [PATCH] Error cannot be reached

Cameron McInally mcinally at cray.com
Sat May 14 09:55:11 PDT 2011


Ah, right. Good point. When I have some free time, I'll investigate further. Thanks for your help, Bob.
________________________________________
From: Bob Wilson [bob.wilson at apple.com]
Sent: Saturday, May 14, 2011 1:09 AM
To: Cameron McInally
Cc: Chris Lattner; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Error cannot be reached

...  If OpName is empty, the previous code would skip over "Args.push_back(OpName)" without calling error().  With the patch, it will now produce an error().  It isn't at all obvious that is the right thing to do.




More information about the llvm-commits mailing list