[llvm-commits] [llvm] r131339 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCompares.cpp test/Transforms/InstCombine/2011-05-13-InBoundsGEP.ll

[Benjamin Kramer]

On 14.05.2011, at 07:55, Stuart Hastings wrote:

> Author: stuart
> Date: Sat May 14 00:55:10 2011
> New Revision: 131339
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=131339&view=rev
> Log:
> Avoid combining GEPs that might overflow at runtime.
> rdar://problem/9267970
> 
> Patch by Julien Lerouge!
[…]
> Added: llvm/trunk/test/Transforms/InstCombine/2011-05-13-InBoundsGEP.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/2011-05-13-InBoundsGEP.ll?rev=131339&view=auto
> ==============================================================================
> --- llvm/trunk/test/Transforms/InstCombine/2011-05-13-InBoundsGEP.ll (added)
> +++ llvm/trunk/test/Transforms/InstCombine/2011-05-13-InBoundsGEP.ll Sat May 14 00:55:10 2011
> @@ -0,0 +1,19 @@
> +; RUN: opt < %s -instcombine | lli
> +; rdar://problem/9267970
> +; ideally this test will run on a 32-bit host

… but it fails on all other hosts. Please put a target datalayout in there if you want to test for specific platforms.
Also, executable tests are strongly discouraged, this test should be converted to use FileCheck instead of
executing it with lli.