[llvm-commits] [llvm] r131205 - in /llvm/trunk/lib/MC: ELFObjectWriter.cpp ELFObjectWriter.h

[Renato Golin]

On 12 May 2011 17:50, Jason Kim <jasonwkim at google.com> wrote:
> Yah, we've gone back and forth on that.

I know the feeling, it's never good enough... ;)


> Currently it calls out to AsmBackend.getFixupKind() which is pretty
> much the same thing (i.e. arch specific and virtual).
> AsmBackend has a arch specific table with a flag that tells whether a
> relflag is pcrel or not.

I see. I was just worried with the "isPCRel" being too specific to be
a whole new argument for all those functions, as if the separation
between pc-rel and non-pc-rel was the only possible/interesting among
relocations kinds...

But that's minor, since it's already target-specific.

cheers!
--renato