[llvm-commits] [PATCH] A patch to add vector SHL/SRL/SRA support for x86

[Rotem, Nadav]

There is no v2i64 sra instruction. I will make the corrections and commit. 

Thanks.

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Duncan Sands
Sent: Tuesday, May 10, 2011 15:44
To: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] A patch to add vector SHL/SRL/SRA support for x86

Hi Nadav,

> +    setOperationAction(ISD::SRA,               MVT::v4i32, Custom);
> +    setOperationAction(ISD::SRA,               MVT::v8i16, Custom);

so there is no v2i64 arithmetic right shift?

> +  // Must have SSE2
> +  if(! Subtarget->hasSSE2()) return SDValue();

There should be a space between "if" and "(" and no space after "!".  This
problem occurs also in the SSE 4.1 test.

> -  if (VT == MVT::v4i32) {
> +  // Optimize shl/srl with constant shift amount

There should be a full stop at the end of the comment.  The comment doesn't
mention sra but it is handled too.

Otherwise it looks OK to me.

Ciao, Duncan.
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.