[llvm-commits] [llvm] r130943 - /llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp

[Duncan Sands]

Hi Andrew,

> --- llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp (original)
> +++ llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp Thu May  5 14:32:21 2011
> @@ -393,6 +393,18 @@
>           UseList.clear();
>           if (!MO.isDead())
>             DefList.clear();
> +
> +        // Calls will not be reordered because of chain dependencies (see
> +        // below). Since call operands are dead, calls may continue to be added
> +        // to the DefList making dependence checking quadratic in the size of
> +        // the block. Instead, we leave only one call at the back of the
> +        // DefList.
> +        //
> +        // NOTE: This assumes that the DefList is ordered!

that suggests adding a check that DefList is ordered.

Ciao, Duncan.