[llvm-commits] [llvm] r130894 - /llvm/trunk/lib/Transforms/Utils/LCSSA.cpp

[Chris Lattner]

On May 4, 2011, at 4:58 PM, Devang Patel wrote:

> Author: dpatel
> Date: Wed May  4 18:58:22 2011
> New Revision: 130894
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=130894&view=rev
> Log:
> Set debug location for new PHI nodes created in exit block. 

Devang,

What does a debug loc even mean for a PHI node?  Conceptually a phi node is a copy in each of the predecessors, certainly it can't have a single debug loc?

-Chris

> 
> Modified:
>    llvm/trunk/lib/Transforms/Utils/LCSSA.cpp
> 
> Modified: llvm/trunk/lib/Transforms/Utils/LCSSA.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LCSSA.cpp?rev=130894&r1=130893&r2=130894&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Utils/LCSSA.cpp (original)
> +++ llvm/trunk/lib/Transforms/Utils/LCSSA.cpp Wed May  4 18:58:22 2011
> @@ -36,6 +36,7 @@
> #include "llvm/Analysis/Dominators.h"
> #include "llvm/Analysis/LoopPass.h"
> #include "llvm/Analysis/ScalarEvolution.h"
> +#include "llvm/Transforms/Utils/BasicBlockUtils.h"
> #include "llvm/Transforms/Utils/SSAUpdater.h"
> #include "llvm/ADT/Statistic.h"
> #include "llvm/ADT/STLExtras.h"
> @@ -226,6 +227,7 @@
>                                   PredCache.GetNumPreds(ExitBB),
>                                   Inst->getName()+".lcssa",
>                                   ExitBB->begin());
> +    PN->setDebugLoc(GetFirstDebugLocInBasicBlock(ExitBB));
> 
>     // Add inputs from inside the loop for this PHI.
>     for (BasicBlock **PI = PredCache.GetPreds(ExitBB); *PI; ++PI) {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits