[llvm-commits] Fix an encoding issue with ARM PKH* instructions for non-MC path

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Tue May 3 18:34:22 PDT 2011


Hi Stephen,

On Tue, May 3, 2011 at 10:24 PM, Stephen Hines <srhines at google.com> wrote:
> Hi,
> I am sending this patch because I found that the non-MC ARM path was
> incorrectly encoding ARM PKH* instructions. They would essentially be
> encoded twice, where the second encoding would unwrap the shift amount in a
> way that register fields could be clobbered (by the shift amount/encoding).
> I do not have commit privileges, so I would appreciate it if someone could
> submit this for me. All current tests pass with this change, since I am
> using the non-MC path.

Nice! Could you add an encoding test to the patch? See test/MC/ARM for examples.

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc



More information about the llvm-commits mailing list