[llvm-commits] [llvm] r130241 - in /llvm/trunk: include/llvm/Support/StandardPasses.h test/Transforms/PhaseOrdering/ test/Transforms/PhaseOrdering/basic.ll test/Transforms/ScalarRepl/dg.exp

[Chris Lattner]

On Apr 26, 2011, at 11:57 PM, Duncan Sands wrote:

> Hi Chris,
> 
>> 2. Move the "clean up after the unroller" pass to the very end of the
>>    function-level pass pipeline.  Loop unroll uses instsimplify now,
>>    so it doesn't create a ton of trash.  Moving instcombine later allows
>>    it to clean up after opportunities are exposed by GVN, DSE, etc.
> 
> am I right in thinking that there is no longer any point to having instcombine
> try to preserve LCSSA form?  If so, I will rip that code out.

Yep, I'm pretty sure that we haven't been running instcombine in the loop pass manager for quite a while.  Cameron, is this true?

-Chris