[llvm-commits] [llvm] r130170 - in /llvm/trunk/lib/CodeGen/AsmPrinter: DwarfCompileUnit.cpp DwarfCompileUnit.h DwarfDebug.cpp

Devang Patel dpatel at apple.com
Mon Apr 25 16:02:17 PDT 2011


Author: dpatel
Date: Mon Apr 25 18:02:17 2011
New Revision: 130170

URL: http://llvm.org/viewvc/llvm-project?rev=130170&view=rev
Log:
Rename a method to match what it really does.
s/addVariableAddress/addFrameVariableAddress/g

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp?rev=130170&r1=130169&r2=130170&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp Mon Apr 25 18:02:17 2011
@@ -192,9 +192,10 @@
   addUInt(Die, dwarf::DW_AT_decl_line, 0, Line);
 }
 
-/// addVariableAddress - Add DW_AT_location attribute for a DbgVariable based
-/// on provided frame index.
-void CompileUnit::addVariableAddress(DbgVariable *&DV, DIE *Die, int64_t FI) {
+/// addFrameVariableAddress - Add DW_AT_location attribute for a 
+/// DbgVariable based on provided frame index.
+void CompileUnit::addFrameVariableAddress(DbgVariable *&DV, DIE *Die, 
+                                          int64_t FI) {
   MachineLocation Location;
   unsigned FrameReg;
   const TargetFrameLowering *TFI = Asm->TM.getFrameLowering();

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h?rev=130170&r1=130169&r2=130170&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h Mon Apr 25 18:02:17 2011
@@ -212,9 +212,9 @@
   void addBlockByrefAddress(DbgVariable *&DV, DIE *Die, unsigned Attribute,
                             const MachineLocation &Location);
 
-  /// addVariableAddress - Add DW_AT_location attribute for a DbgVariable based
-  /// on provided frame index.
-  void addVariableAddress(DbgVariable *&DV, DIE *Die, int64_t FI);
+  /// addFrameVariableAddress - Add DW_AT_location attribute for a DbgVariable 
+  /// based on provided frame index.
+  void addFrameVariableAddress(DbgVariable *&DV, DIE *Die, int64_t FI);
 
   /// addToContextOwner - Add Die into the list of its context owner's children.
   void addToContextOwner(DIE *Die, DIDescriptor Context);

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=130170&r1=130169&r2=130170&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Mon Apr 25 18:02:17 2011
@@ -696,7 +696,8 @@
         const TargetRegisterInfo *TRI = Asm->TM.getRegisterInfo();
         if (DVInsn->getOperand(1).isImm() &&
             TRI->getFrameRegister(*Asm->MF) == RegOp.getReg()) {
-          TheCU->addVariableAddress(DV, VariableDie, DVInsn->getOperand(1).getImm());
+          TheCU->addFrameVariableAddress(DV, VariableDie, 
+                                         DVInsn->getOperand(1).getImm());
           updated = true;
         } else
           updated = TheCU->addRegisterAddress(VariableDie, RegOp);
@@ -730,7 +731,7 @@
   // .. else use frame index, if available.
   int FI = 0;
   if (findVariableFrameIndex(DV, &FI))
-    TheCU->addVariableAddress(DV, VariableDie, FI);
+    TheCU->addFrameVariableAddress(DV, VariableDie, FI);
   
   DV->setDIE(VariableDie);
   return VariableDie;





More information about the llvm-commits mailing list