[llvm-commits] [PATCHES] fix duplication and FIXMEs in JIT code

[nobled]

(Just so you know, I do have commit access.)

These patches address this comment from the MCJIT code:

  // FIXME: This should be lifted out of here, it isn't something which should
  // be part of the JIT policy, rather the burden for this selection should be
  // pushed to clients.
====
[PATCH 1/3] ExecutionEngine: fix JIT/MCJIT selectTarget() duplication

(Merges the near-identical files lib/EE/JIT/TargetSelect.cpp and
lib/EE/MCJIT/TargetSelect.cpp into lib/EE/TargetSelect.cpp.)

This prepares for making JITCtor/MCJITCtor take a
TargetMachine* directly from clients like EngineBuilder.
====
[PATCH 2/3] ExecutionEngine: push TargetMachine creation into clients

In particular, into EngineBuilder. This should only impact
the private API between the EE and EB classes, not external
clients, since JITCtor and MCJITCtor are both protected members.
====
[PATCH 3/3] ExecutionEngine: move createJIT definition

As an ExecutionEngine class function, its definition
really belongs in ExecutionEngine.cpp instead of in JIT.cpp.
====

As for this comment:

   // Try to register the program as a source of symbols to resolve against.
   //
   // FIXME: Don't do this here.
   sys::DynamicLibrary::LoadLibraryPermanently(0, NULL);

where in the stack *should* that go, ideally?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ExecutionEngine-fix-JIT-MCJIT-selectTarget-duplicati.patch
Type: text/x-patch
Size: 17688 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110424/2807f027/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ExecutionEngine-push-TargetMachine-creation-into-cli.patch
Type: text/x-patch
Size: 9324 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110424/2807f027/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ExecutionEngine-move-createJIT-definition.patch
Type: text/x-patch
Size: 3623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110424/2807f027/attachment-0002.bin>