[llvm-commits] [LLVMbugs] [Bug 9761] New: AsmPrinter::EmitEndOfAsmFile is not the final code emission point.

[Villmow, Micah]

> -----Original Message-----
> From: Eric Christopher [mailto:echristo at apple.com]
> Sent: Thursday, April 21, 2011 4:13 PM
> To: Villmow, Micah
> Cc: llvm-commits
> Subject: Re: [llvm-commits] [LLVMbugs] [Bug 9761] New:
> AsmPrinter::EmitEndOfAsmFile is not the final code emission point.
> 
> 
> On Apr 21, 2011, at 4:12 PM, Villmow, Micah wrote:
> 
> >
> >
> >> -----Original Message-----
> >> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> >> bounces at cs.uiuc.edu] On Behalf Of Eric Christopher
> >> Sent: Thursday, April 21, 2011 3:59 PM
> >> To: Villmow, Micah
> >> Cc: llvm-commits
> >> Subject: Re: [llvm-commits] [LLVMbugs] [Bug 9761] New:
> >> AsmPrinter::EmitEndOfAsmFile is not the final code emission point.
> >>
> >>
> >> On Apr 21, 2011, at 3:05 PM, Villmow, Micah wrote:
> >>
> >>> I've attached a patch for this bug,  would it be possible to get a
> >> review and commit? It seems like a rather benign change.
> >>
> >> Few comments:
> >>
> >> a) Don't bother to put bug comments into the code. It just makes it
> >> annoying to read.
> > [Villmow, Micah] Ok, I will keep that in mind for the future.
> >> b) How did you test this?
> > [Villmow, Micah] I'm still working on getting LLVM testing
> infrastructure
> > working in my spare time. It passes all of our internal testing
> > outside of LLVM with our custom backend and x86 backend
> 
> configure and make check doesn't work for you?
[Villmow, Micah] Using visual studio 2008 currently, not linux/cygwin.
> 
> -eric
>