[llvm-commits] [cfe-commits] [PATCH] convert the Metadata API to use ArrayRef<>

[Frits van Bommel]

On Thu, Apr 21, 2011 at 5:05 PM, Jay Foad <jay.foad at gmail.com> wrote:
> Related to http://llvm.org/bugs/show_bug.cgi?id=9214
>
> This patch converts the Metadata API (principally MDNode::get*()) to
> use ArrayRef<>.
>
> I've converted the llvm and clang trees (tested with "make check") and

"make check" only tests llvm itself. To also test clang, use "make check-all".

> also dragonegg (only tested by building it). Other clients will also
> need updating. (Clients that just use DIBuilder to created debug info
> metadata won't need any changes.)
>
> OK to commit?

You have an 80-column violation in DIBuilder::getOrCreateArray() (and
there already was one in the function signature).

Other than those two nitpicks, LGTM.