[llvm-commits] [llvm] r129845 - /llvm/trunk/lib/Target/X86/X86InstrInfo.td

[Chris Lattner]

On Apr 19, 2011, at 8:19 PM, Nick Lewycky wrote:

> Author: nicholas
> Date: Tue Apr 19 22:19:42 2011
> New Revision: 129845
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=129845&view=rev
> Log:
> This should always be signed chars, so use int8_t. This fixes a miscompile when
> llvm is built with unsigned chars where an immediate such as 0xff would be zero
> extended to 64-bits, turning "cmp $0xff,%eax" into
> "cmp $0xffffffffffffffff,%eax".

Nice catch, thanks!

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110420/55cd4852/attachment.html>