[llvm-commits] [llvm] r129761 - /llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

[Stuart Hastings]

On Apr 19, 2011, at 11:15 AM, Dan Gohman wrote:

> On Apr 19, 2011, at 9:16 AM, Stuart Hastings wrote:
>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp?rev=129761&r1=129760&r2=129761&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp Tue Apr 19 11:16:58 2011
>> @@ -61,15 +61,13 @@
>> 
>>  // Libcall insertion helpers.
>> 
>> -  /// LastCALLSEQ_END - This keeps track of the CALLSEQ_END node that has been
>> +  /// LastCALLSEQ - This keeps track of the CALLSEQ_END node that has been
>>  /// legalized.  We use this to ensure that calls are properly serialized
>>  /// against each other, including inserted libcalls.
>> -  SDValue LastCALLSEQ_END;
>> +  SmallVector<SDValue, 8> LastCALLSEQ;
>> 
>> -  /// IsLegalizingCall - This member is used *only* for purposes of providing
>> -  /// helpful assertions that a libcall isn't created while another call is
>> -  /// being legalized (which could lead to non-serialized call sequences).
>> -  bool IsLegalizingCall;
>> +  // Track CALLSEQ_BEGIN/CALLSEQ_END nesting.
>> +  int depthCALLSEQ;
> 
> It looks like depthCALLSEQ is only used for asserts, and it's always
> the same as LastCALLSEQ.size(). If so, can it be eliminated?

You're right.  I'll do it.

stuart