[llvm-commits] [PATCH] review request: implementation of bounded StringRef::compare

Lenny Maiorani lenny at Colorado.EDU
Fri Apr 15 09:43:12 PDT 2011


On 04/15/2011 12:40 AM, Duncan Sands wrote:
> Hi Lenny, this function seems a bit big to be declared inline.
>
> Ciao, Duncan.
Thanks for checking it out Duncan. I figured since it was only slightly 
larger than the original compare() it wouldn't be an issue, but you are 
correct, it is getting a little long. Attached is a new patch which 
implements the same thing, but not inlined.

Please review.

-Lenny

-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-bounded-stringref-compare-2.diff
Type: text/x-patch
Size: 3219 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110415/2ea27b72/attachment.bin>


More information about the llvm-commits mailing list