[llvm-commits] [cfe-commits] [PATCH] share code between StringRef and ArrayRef

Chris Lattner clattner at apple.com
Thu Apr 14 08:36:43 PDT 2011

On Apr 14, 2011, at 5:35 AM, Benjamin Kramer wrote:
On 14.04.2011, at 09:56, Jay Foad <jay.foad at gmail.com> wrote:
>> This patch removes a bit of code from StringRef by making it derive
>> from ArrayRef<char>.
>> Comments? OK to commit? The savings aren't huge, so I'm not
>> particularly wedded to the patch.
> Hi Jay,
> Have you checked the compile time impact of this? StringRef.h is included everywhere and ArrayRef.h pulls in Smallvector and Vector which are both big headers. I don't think this is worth it.

Yeah, I tend to agree.  I don't think it's worth it..


More information about the llvm-commits mailing list