[llvm-commits] [llvm] r129497 - in /llvm/trunk: lib/Target/X86/ lib/Target/X86/InstPrinter/ test/CodeGen/X86/ test/MC/X86/

[Bill Wendling]

On Apr 13, 2011, at 6:38 PM, Eric Christopher wrote:

> Awesome.
> 
> One thing...
> 
> On Apr 13, 2011, at 6:11 PM, Bill Wendling wrote:
> 
>> void X86ATTInstPrinter::printInst(const MCInst *MI, raw_ostream &OS) {
>> -  printInstruction(MI, OS);
>> +  if (printAliasInstr(MI, OS))
>> +    printInstruction(MI, OS);
> 
> This looks... awkward?
> 
Maybe...but it's similar to the style used in the parser where a function that returns 'true' didn't succeed in doing what it was supposed to do (like parse a statement or something).

I'm open to ideas, though. :)

-bw