[llvm-commits] [PATCH][RFC] InstrTypes.h: don't include Operator.h

Chris Lattner clattner at apple.com
Sat Apr 9 14:36:37 PDT 2011


On Mar 23, 2011, at 5:00 AM, Jay Foad wrote:

> I noticed that InstrTypes.h include Operator.h, even though it doesn't
> seem to be required for anything in InstrTypes.h. This patch removes
> the include and adjusts a bunch of .cpp files accordingly. Tested with
> "make all check", LLVM and Clang.
> 
> I see this as an improvement, because it makes the header files more
> independent and minimalist. But perhaps you'd prefer that .cpp files
> don't have to explicitly #include Operator.h, when they've already
> asked for all InstrTypes to be defined.

We definitely prefer minimal includes, please commit!

-Chris



More information about the llvm-commits mailing list