[llvm-commits] [llvm] r129040 - /llvm/trunk/lib/VMCore/IRBuilder.cpp

[Nick Lewycky]

Duncan Sands wrote:
> Hi Nick,
>
>> Set unnamed_addr on strings created through the IRBuilder.
>
> why is this correct?  Aren't you inserting C semantics into the IRBuilder?

Why is it wrong? If this is breaking any users, feel free to revert it. 
The problem is that it's hard for the caller to go in after the fact and 
add in the unnamed_addr (it's just gone a 'string pointer').

If you want, we could add a flag I guess, I just thought that all 
production users of the API would actually want this behaviour, so why 
bother with a flag?

Nick