[llvm-commits] [llvm] r128662 - in /llvm/trunk: lib/Target/ARM/ARMInstrInfo.td test/MC/Disassembler/ARM/invalid-LDRrs-arm.txt

[Johnny Chen]

Hi Owen,

There are a lot of places in the ARMInstrInfo.td which use the variable shift as a logical unit,
and distributes the fragments of variable shift to various parts of the Inst.  I was guessing that
it could eventually be used for JITing purposes and I don't like to disturb the pattern.

If this is not true, I'll just write:

    let Inst{4} = 0;

and change the variable shift to have:

    bits<16> shift;

instead of:

    bits<17> shift;

Please let me know.  Thanks.

On Mar 31, 2011, at 2:05 PM, Owen Anderson wrote:

> Johnny,
> 
> On Mar 31, 2011, at 12:28 PM, Johnny Chen wrote:
>> +    let shift{4}    = 0;            // Inst{4} = 0
> 
> Why are assigning to shift{4} rather than to Inst{4}?  The latter is consistent with how we handle this in other places.
> 
> --Owen