[llvm-commits] [llvm] r128650 - in /llvm/trunk: lib/Target/Mips/MipsISelLowering.cpp lib/Target/Mips/MipsISelLowering.h lib/Target/Mips/MipsInstrFPU.td lib/Target/Mips/MipsInstrFormats.td lib/Target/Mips/MipsInstrInfo.cpp lib/Target/Mips/MipsInstrInfo.h lib/Target/Mips/MipsInstrInfo.td test/CodeGen/Mips/2008-07-23-fpcmp.ll test/CodeGen/Mips/2008-07-29-icmp.ll test/CodeGen/Mips/2010-07-20-Select.ll test/CodeGen/Mips/fpbr.ll test/CodeGen/Mips/fpcmp.ll test/CodeGen/Mips/select.ll

[Jakob Stoklund Olesen]

On Mar 31, 2011, at 11:26 AM, Akira Hatanaka wrote:

> Modified: llvm/trunk/test/CodeGen/Mips/2010-07-20-Select.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/2010-07-20-Select.ll?rev=128650&r1=128649&r2=128650&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/Mips/2010-07-20-Select.ll (original)
> +++ llvm/trunk/test/CodeGen/Mips/2010-07-20-Select.ll Thu Mar 31 13:26:17 2011
> @@ -9,12 +9,12 @@
>   volatile store i32 0, i32* %c, align 4
>   %0 = volatile load i32* %a, align 4             ; <i32> [#uses=1]
>   %1 = icmp eq i32 %0, 0                          ; <i1> [#uses=1]
> -; CHECK: addiu $3, $zero, 0
> +; CHECK: addiu $4, $zero, 0
>   %iftmp.0.0 = select i1 %1, i32 3, i32 0         ; <i32> [#uses=1]
>   %2 = volatile load i32* %c, align 4             ; <i32> [#uses=1]
>   %3 = icmp eq i32 %2, 0                          ; <i1> [#uses=1]
> -; CHECK: addiu $3, $zero, 3
> -; CHECK: addu $2, $5, $3
> +; CHECK: addiu $4, $zero, 3
> +; CHECK: addu $2, $3, $4
>   %iftmp.2.0 = select i1 %3, i32 0, i32 5         ; <i32> [#uses=1]
>   %4 = add nsw i32 %iftmp.2.0, %iftmp.0.0         ; <i32> [#uses=1]
>   ret i32 %4

Please don't write tests that depend on arbitrary register allocation choices. Use FileCheck patterns instead.

I just fixed this one in r128654.

/jakob