[llvm-commits] [llvm] r128537 - in /llvm/trunk: docs/tutorial/ examples/BrainF/ examples/Kaleidoscope/Chapter5/ examples/Kaleidoscope/Chapter6/ examples/Kaleidoscope/Chapter7/ include/llvm/ include/llvm/Support/ lib/Analysis/ lib/AsmParser/ lib/B

Duncan Sands baldrick at free.fr
Wed Mar 30 06:08:51 PDT 2011


Hi Jay,

> It shouldn't make things more awkward for anyone. If you really don't
> have any information about how many operands the phi node will have,
> you can create it with 0. This should be exactly equivalent to how
> PHINode::Create() method worked before my changes.
>
> The NumReservedValues parameter that I've added to PHINode::Create()
> is just a hint, just like the old reserveOperandSpace() method. It
> doesn't have to be exactly the right number.

in that case there is no problem - I have adjusted dragonegg.  By the
way you forgot to document the NumReservedValues parameter you added
to PHINode::Create.

Ciao, Duncan.



More information about the llvm-commits mailing list