[llvm-commits] [llvm] r128452 - /llvm/trunk/lib/CodeGen/StackProtector.cpp

[Cameron Zwarich]

On 2011-03-29, at 12:06 AM, Bill Wendling wrote:

> On Mar 28, 2011, at 10:35 PM, Eli Friedman wrote:
> 
>> On Mon, Mar 28, 2011 at 10:15 PM, Bill Wendling <isanbard at gmail.com> wrote:
>> 
>> That isn't a safe way to query whether a block is usable... if you
>> have domtree, why not just use "DT->isReachableFromEntry(BB)"?
>> 
> It's probably rather slow. Why isn't this safe?

You can have an unreachable loop. Using isReachableFromEntry() was fast the last time I checked. It just checks whether the BB has a DomTreeNode.

Cameron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110329/1c8c71d1/attachment.html>