[llvm-commits] [PATCH][RFC] InstrTypes.h: don't include Operator.h

Jay Foad jay.foad at gmail.com
Wed Mar 23 05:00:23 PDT 2011


I noticed that InstrTypes.h include Operator.h, even though it doesn't
seem to be required for anything in InstrTypes.h. This patch removes
the include and adjusts a bunch of .cpp files accordingly. Tested with
"make all check", LLVM and Clang.

I see this as an improvement, because it makes the header files more
independent and minimalist. But perhaps you'd prefer that .cpp files
don't have to explicitly #include Operator.h, when they've already
asked for all InstrTypes to be defined.

Thoughts?

Thanks,
Jay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: instrtypes-operator.diff
Type: text/x-patch
Size: 10627 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110323/80349d33/attachment.bin>


More information about the llvm-commits mailing list