[llvm-commits] [dragonegg] r127999 - /dragonegg/trunk/Constants.cpp

Duncan Sands baldrick at free.fr
Mon Mar 21 08:51:29 PDT 2011


Author: baldrick
Date: Mon Mar 21 10:51:29 2011
New Revision: 127999

URL: http://llvm.org/viewvc/llvm-project?rev=127999&view=rev
Log:
The failing testcases fail also if this check is disabled, so may as
well turn it back on.

Modified:
    dragonegg/trunk/Constants.cpp

Modified: dragonegg/trunk/Constants.cpp
URL: http://llvm.org/viewvc/llvm-project/dragonegg/trunk/Constants.cpp?rev=127999&r1=127998&r2=127999&view=diff
==============================================================================
--- dragonegg/trunk/Constants.cpp (original)
+++ dragonegg/trunk/Constants.cpp Mon Mar 21 10:51:29 2011
@@ -1347,12 +1347,10 @@
     break;
   }
 
-// FIXME: The call to ConvertType blows up on several objective C testcases,
-// also on vtable-layout.cpp.
-//  assert((!ConvertType(TREE_TYPE(exp))->isSized() ||
-//          getTargetData().getTypeAllocSizeInBits(ConvertType(TREE_TYPE(exp))) <=
-//          getTargetData().getTypeAllocSizeInBits(Init->getType())) &&
-//         "Constant too small for type!");
+  assert((!ConvertType(TREE_TYPE(exp))->isSized() ||
+          getTargetData().getTypeAllocSizeInBits(ConvertType(TREE_TYPE(exp))) <=
+          getTargetData().getTypeAllocSizeInBits(Init->getType())) &&
+         "Constant too small for type!");
 // FIXME: This check fails when building libdecnumber (self-host build).
 //  assert(getTargetData().getABITypeAlignment(Init->getType()) * 8 <=
 //         TYPE_ALIGN(TREE_TYPE(exp)) && "Constant over aligned!");





More information about the llvm-commits mailing list