[llvm-commits] [llvm] r127849 - in /llvm/trunk: include/llvm/Support/CrashRecoveryContext.h lib/Support/CrashRecoveryContext.cpp

[Ted Kremenek]

Author: kremenek
Date: Thu Mar 17 21:05:11 2011
New Revision: 127849

URL: http://llvm.org/viewvc/llvm-project?rev=127849&view=rev
Log:
Augment CrashRecoveryContext to have registered "cleanup" objects that can be used to release resources during a crash.

Modified:
    llvm/trunk/include/llvm/Support/CrashRecoveryContext.h
    llvm/trunk/lib/Support/CrashRecoveryContext.cpp

Modified: llvm/trunk/include/llvm/Support/CrashRecoveryContext.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/CrashRecoveryContext.h?rev=127849&r1=127848&r2=127849&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/CrashRecoveryContext.h (original)
+++ llvm/trunk/include/llvm/Support/CrashRecoveryContext.h Thu Mar 17 21:05:11 2011
@@ -15,6 +15,8 @@
 namespace llvm {
 class StringRef;
 
+class CrashRecoveryContextCleanup;
+  
 /// \brief Crash recovery helper object.
 ///
 /// This class implements support for running operations in a safe context so
@@ -42,10 +44,14 @@
 /// Crash recovery contexts may not be nested.
 class CrashRecoveryContext {
   void *Impl;
+  CrashRecoveryContextCleanup *head;
 
 public:
-  CrashRecoveryContext() : Impl(0) {}
+  CrashRecoveryContext() : Impl(0), head(0) {}
   ~CrashRecoveryContext();
+  
+  void registerCleanup(CrashRecoveryContextCleanup *cleanup);
+  void unregisterCleanup(CrashRecoveryContextCleanup *cleanup);
 
   /// \brief Enable crash recovery.
   static void Enable();
@@ -87,6 +93,64 @@
   const std::string &getBacktrace() const;
 };
 
+class CrashRecoveryContextCleanup {
+public:
+  virtual ~CrashRecoveryContextCleanup();
+  virtual void recoverResources() = 0;
+  
+  template <typename T> static CrashRecoveryContextCleanup *create(T *);
+  
+private:
+  friend class CrashRecoveryContext;
+  CrashRecoveryContextCleanup *prev, *next;
+};
+
+template <typename T>
+class CrashRecoveryContextDestructorCleanup 
+  : public CrashRecoveryContextCleanup
+{
+  T *resource;
+public:
+  CrashRecoveryContextDestructorCleanup(T *resource) : resource(resource) {}
+  virtual void recoverResources() {
+    resource->~T();
+  }
+};
+  
+template <typename T>
+struct CrashRecoveryContextTrait {
+  static inline CrashRecoveryContextCleanup *createCleanup(T *resource) {
+    return new CrashRecoveryContextDestructorCleanup<T>(resource);
+  }
+};
+
+template<typename T>
+inline CrashRecoveryContextCleanup* CrashRecoveryContextCleanup::create(T *x) {
+  return CrashRecoveryContext::GetCurrent() ?
+          CrashRecoveryContextTrait<T>::createCleanup(x) : 
+          0;
+}
+
+class CrashRecoveryContextCleanupRegistrar {
+  CrashRecoveryContext *context;
+  CrashRecoveryContextCleanup *cleanup;
+public:
+  CrashRecoveryContextCleanupRegistrar(CrashRecoveryContextCleanup *cleanup)
+    : context(CrashRecoveryContext::GetCurrent()),
+      cleanup(cleanup) 
+  {
+    if (context && cleanup)
+      context->registerCleanup(cleanup);
+  }
+  ~CrashRecoveryContextCleanupRegistrar() {
+    if (cleanup) {
+      if (context)
+        context->unregisterCleanup(cleanup);
+      else
+        delete cleanup;
+    }
+  }
+};
 }
 
 #endif

Modified: llvm/trunk/lib/Support/CrashRecoveryContext.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/CrashRecoveryContext.cpp?rev=127849&r1=127848&r2=127849&view=diff
==============================================================================
--- llvm/trunk/lib/Support/CrashRecoveryContext.cpp (original)
+++ llvm/trunk/lib/Support/CrashRecoveryContext.cpp Thu Mar 17 21:05:11 2011
@@ -57,7 +57,18 @@
 static sys::Mutex gCrashRecoveryContexMutex;
 static bool gCrashRecoveryEnabled = false;
 
+CrashRecoveryContextCleanup::~CrashRecoveryContextCleanup() {}
+
 CrashRecoveryContext::~CrashRecoveryContext() {
+  // Reclaim registered resources.
+  CrashRecoveryContextCleanup *i = head;
+  while (i) {
+    CrashRecoveryContextCleanup *tmp = i;
+    i = tmp->next;
+    tmp->recoverResources();
+    delete tmp;
+  }
+  
   CrashRecoveryContextImpl *CRCI = (CrashRecoveryContextImpl *) Impl;
   delete CRCI;
 }
@@ -70,6 +81,33 @@
   return CRCI->CRC;
 }
 
+void CrashRecoveryContext::registerCleanup(CrashRecoveryContextCleanup *cleanup)
+{
+  if (!cleanup)
+    return;
+  if (head)
+    head->prev = cleanup;
+  cleanup->next = head;
+  head = cleanup;
+}
+
+void
+CrashRecoveryContext::unregisterCleanup(CrashRecoveryContextCleanup *cleanup) {
+  if (!cleanup)
+    return;
+  if (cleanup == head) {
+    head = cleanup->next;
+    if (head)
+      head->prev = 0;
+  }
+  else {
+    cleanup->prev->next = cleanup->next;
+    if (cleanup->next)
+      cleanup->next->prev = cleanup->prev;
+  }
+  delete cleanup;
+}
+
 #ifdef LLVM_ON_WIN32
 
 // FIXME: No real Win32 implementation currently.