[llvm-commits] [llvm] r127766 - in /llvm/trunk: docs/LangRef.html include/llvm/Target/TargetLowering.h lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h test/CodeGen/X86/bool-zext

Ken Dyck kd at kendyck.com
Thu Mar 17 04:38:24 PDT 2011


On Wed, Mar 16, 2011 at 8:26 PM, Cameron Zwarich <zwarich at apple.com> wrote:
> On Mar 16, 2011, at 5:17 PM, Evan Cheng wrote:
>
>> Thanks. But I am not crazy about getTypeForExtendedInteger(). Can you name it better so it's clear it's used for argument passing and return values?
>>
> I am not too crazy about the name either. I originally had it named something
> return-specific (since my patch is return-specific), but remembered it also applies
> to the argument case. Anyone have any suggestions? I will try to think about it
> and change it to something better...

The LangRef refers to signext and zeroext as parameter attributes, so
how about getTypeForExtendedIntegerParameter()? Or
getTypeForIntegerParameterExtension().

-Ken



More information about the llvm-commits mailing list