[llvm-commits] [Review request] MaybeFolder (was: Fold() function on TargetFolder class - removal of redundant constantexpr)

Frits van Bommel fvbommel at gmail.com
Wed Mar 9 23:27:18 PST 2011


On Sun, Mar 6, 2011 at 3:06 PM, Frits van Bommel <fvbommel at gmail.com> wrote:
> On Tue, Mar 1, 2011 at 3:40 PM, Duncan Sands <baldrick at free.fr> wrote:
>> thanks for the suggestion.  I guess another way of doing this is to create a
>> new
>> folder class that dispatches to a target folder or a no folder depending on
>> the
>> value of some flag.
>
> Something like the (second) attached patch?
>
> The first one just removes the LLVMContext& argument from *Folder
> constructors, as it doesn't seem to be used anywhere. I noticed this
> while working on the second one.
>
> The second one adds a MaybeFolder and a little support in IRBuilder to
> make it work.

ping?




More information about the llvm-commits mailing list