[llvm-commits] [llvm] r127097 - /llvm/trunk/include/llvm/CodeGen/MachineInstr.h

[Villmow, Micah]

Anton,
 Is there a reason why this is being shortened to 8 bits? I currently need all 16 bits in AMD's backend and this would break our backend if we sync to past this changelist.

Micah

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Anton Korobeynikov
> Sent: Saturday, March 05, 2011 10:43 AM
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm-commits] [llvm] r127097 -
> /llvm/trunk/include/llvm/CodeGen/MachineInstr.h
> 
> Author: asl
> Date: Sat Mar  5 12:42:54 2011
> New Revision: 127097
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=127097&view=rev
> Log:
> Shorten AsmPrinterFlags filed to accomodate for future Flags field
> 
> Modified:
>     llvm/trunk/include/llvm/CodeGen/MachineInstr.h
> 
> Modified: llvm/trunk/include/llvm/CodeGen/MachineInstr.h
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/include/llvm/CodeGen/MachineInstr.h?rev=127097&r1=12
> 7096&r2=127097&view=diff
> =======================================================================
> =======
> --- llvm/trunk/include/llvm/CodeGen/MachineInstr.h (original)
> +++ llvm/trunk/include/llvm/CodeGen/MachineInstr.h Sat Mar  5 12:42:54
> 2011
> @@ -53,10 +53,10 @@
> 
>  private:
>    const TargetInstrDesc *TID;           // Instruction descriptor.
> -  unsigned short NumImplicitOps;        // Number of implicit operands
> (which
> +  uint16_t NumImplicitOps;              // Number of implicit operands
> (which
>                                          // are determined at
> construction time).
> 
> -  unsigned short AsmPrinterFlags;       // Various bits of information
> used by
> +  uint8_t AsmPrinterFlags;              // Various bits of information
> used by
>                                          // the AsmPrinter to emit
> helpful
>                                          // comments.  This is *not*
> semantic
>                                          // information.  Do not use
> this for
> @@ -125,7 +125,7 @@
> 
>    /// getAsmPrinterFlags - Return the asm printer flags bitvector.
>    ///
> -  unsigned short getAsmPrinterFlags() const { return AsmPrinterFlags;
> }
> +  uint8_t getAsmPrinterFlags() const { return AsmPrinterFlags; }
> 
>    /// clearAsmPrinterFlags - clear the AsmPrinter bitvector
>    ///
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits