[llvm-commits] [llvm] r126963 - in /llvm/trunk: lib/MC/ test/CodeGen/ARM/ test/CodeGen/Blackfin/ test/CodeGen/CellSPU/ test/CodeGen/Mips/ test/CodeGen/PowerPC/ test/CodeGen/X86/ test/CodeGen/XCore/ test/MC/ELF/

[Joerg Sonnenberger]

On Fri, Mar 04, 2011 at 05:03:52PM +0000, Richard Osborne wrote:
> On 04/03/11 15:33, Joerg Sonnenberger wrote:
> > On Fri, Mar 04, 2011 at 02:20:29PM +0000, Richard Osborne wrote:
> >> This breaks on the XCore - the toolchain doesn't use gas and the XMOS
> >> assembler doesn't accept strings as section names. Would it be possible
> >> to make the quoting conditional on whether the section name actually
> >> requires quoting?
> > Well, that brings up two important questions:
> >
> > (a) What does the XMOS assembler do with section names containing e.g.
> > quotes or spaces. There is an existing test case for that.
> The XMOS assembler only accepts section names that use letters, numbers, 
> '_' and '.'. We could add support for quoted section names to be more 
> compatible with gas, but that it would take time for a new release 
> containing this change to become available. Conditionally quoting 
> section names avoids breaking the assembly output for section names that 
> we currently use on the XCore.

OK, attached patch uses that uses unquoted names iff they match the
above set of characters.

Joerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quoted-names3.diff
Type: text/x-diff
Size: 12351 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110304/85279ff6/attachment.diff>