[llvm-commits] sys::fs::can_read() and sys::fs::can_write() for Unix

[Liam Staskawicz]

On Wed, Mar 2, 2011 at 12:14 PM, Dan Gohman <gohman at apple.com> wrote:

>
> On Mar 2, 2011, at 7:54 AM, Liam Staskawicz wrote:
>
> ping.
>
> Is anybody available to review and commit if OK?  Thanks!
>
> Liam
> Forwarded message:
>
> From: Liam Staskawicz <lstask at gmail.com>
> To: llvm-commits at cs.uiuc.edu
> Date: Monday, February 28, 2011 10:39:43 AM
> Subject: [PATCH] sys::fs::can_read() and sys::fs::can_write() for Unix
>
> Hi - the attached patch provides implementations and tests for
> sys::fs::can_read() and sys::fs::can_write() for Unix.  These were adapted
> from the previous implementations in lib/Support/Unix/Path.inc.
>  can_execute() could be implemented quite similarly, but I wasn't sure where
> the best place to add a test for it would be, so left it out for now.
>
>
> I'm surprised that anything in LLVM and clang is actually using canWrite().
> It appears that there is one use, in clang, and that one looks pretty
> suspicious. Perhaps it can be removed altogether instead of ported to
> PathV2?
>
> Dan
>
>
Removing it altogether would actually be fine from my perspective, though it
would be good to know what the plan is, so I can plan accordingly.  Thanks.


Liam
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110302/614a3aa5/attachment.html>