[llvm-commits] [llvm] r126787 - /llvm/trunk/include/llvm/Support/SourceMgr.h

[Chris Lattner]

On Mar 1, 2011, at 2:11 PM, Dan Gohman wrote:

> Author: djg
> Date: Tue Mar  1 16:11:52 2011
> New Revision: 126787
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=126787&view=rev
> Log:
> Remove the showline argument from the SMDiagnostic constructor
> which constructs a diagnostic with no line to show.

Hi Dan,

Removing the option sounds fine, but doesn't this patch silently switch it from 'true' to 'false'?

-Chris

> 
> Modified:
>    llvm/trunk/include/llvm/Support/SourceMgr.h
> 
> Modified: llvm/trunk/include/llvm/Support/SourceMgr.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/SourceMgr.h?rev=126787&r1=126786&r2=126787&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/SourceMgr.h (original)
> +++ llvm/trunk/include/llvm/Support/SourceMgr.h Tue Mar  1 16:11:52 2011
> @@ -156,10 +156,9 @@
>   // Null diagnostic.
>   SMDiagnostic() : SM(0), LineNo(0), ColumnNo(0), ShowLine(0) {}
>   // Diagnostic with no location (e.g. file not found, command line arg error).
> -  SMDiagnostic(const std::string &filename, const std::string &Msg,
> -               bool showline = true)
> +  SMDiagnostic(const std::string &filename, const std::string &Msg)
>     : SM(0), Filename(filename), LineNo(-1), ColumnNo(-1),
> -      Message(Msg), ShowLine(showline) {}
> +      Message(Msg), ShowLine(false) {}
> 
>   // Diagnostic with a location.
>   SMDiagnostic(const SourceMgr &sm, SMLoc L, const std::string &FN,
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits