[llvm-commits] [llvm] r126714 - in /llvm/trunk: include/llvm/Constants.h lib/VMCore/Constants.cpp

[Talin]

Ah, good catch. Thanks

On Mon, Feb 28, 2011 at 11:19 PM, Frits van Bommel <fvbommel at gmail.com>wrote:

> On Tue, Mar 1, 2011 at 12:53 AM, Talin <viridia at gmail.com> wrote:
> > +Constant* ConstantStruct::get(LLVMContext &Context, bool Packed,
> > +                              Constant * Val, ...) {
> > +  va_list ap;
> > +  std::vector<Constant*> Values;
> > +  va_start(ap, Val);
> > +  while (Val) {
> > +    Values.push_back(Val);
> > +    Val = va_arg(ap, llvm::Constant*);
> > +  }
>
> Shouldn't there technically be a va_end right about here?
> I'm not aware of any platform where that actually does anything, but
> it can't hurt either...
>
> > +  return get(Context, Values, Packed);
> > +}
>



-- 
-- Talin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110301/95cddc98/attachment.html>