[llvm-commits] Console input should be opened in binary mode on Windows (Python setting)

Danil Malyshev dmalyshev at accesssoftek.com
Fri Feb 25 14:14:38 PST 2011


Hello All,

Some tests on Windows fail because these tests use python scripts for analyze binary output from console, but python open it in the text mode.
Attached patch fix it.

The patch fixes the following tests:
    LLVM :: CodeGen/ARM/2010-12-13-reloc-pic.ll
    LLVM :: MC/ARM/elf-reloc-01.ll
    LLVM :: MC/COFF/symbol-alias.s
    LLVM :: MC/ELF/align.s
    LLVM :: MC/ELF/cfi.s
    LLVM :: MC/ELF/relocation.s
    LLVM :: MC/ELF/tls-i386.s
    LLVM :: MC/ELF/weakref.s

Tested in MinGW and Ubuntu.


Thank you,
Danil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110225/1d367d09/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: python-binary-console-01.patch
Type: application/octet-stream
Size: 503 bytes
Desc: python-binary-console-01.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110225/1d367d09/attachment.obj>


More information about the llvm-commits mailing list