[llvm-commits] [llvm] r125595 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/exprs.s test/MC/AsmParser/paren.s

[Chris Lattner]

On Feb 23, 2011, at 6:40 PM, Rafael Ávila de Espíndola wrote:

>> n any case, instead of focusing on who is right or wrong, it is more
>> productive to focus on how to make progress here.  I agree with Jim
>> that reverting the patch for the time being is the right thing to do.
>> It would be great if you could resubmit the patch, adding a target
>> hook at the the ARM assembler can override to disable [] parsing.  I
>> don't think that this would be a major extension to the patch and
>> would be happy to help with it.
>> 
>> Just remember, we're all friends here.  :-)
> 
> Just a nit, it looks like it is a Mach-O X ELF, not X86 x ARM.
> 
> Just to be sure, would this be a desirable feature for X86 Darwin?

Sure, I'd like the mc assembler to be as consistent as reasonable across different OS's.

> Now that I know that existing assemblers for ARM Mach-O don't support
> this, I agree it is not a good idea to be the first one to do so.

*shrug*, the assembler is already a scary place full of compatibility hacks.  I don't think that making it any more complex by disabling upwards compatible extensions is a good way to go.

> Since this is in the expression parser, we probably need a
> HasFunnySquareBracketExpr flag or something, but yes, it should not be a
> big change on top of the previous patch.

Right,

-Chris