[llvm-commits] [llvm] r125595 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/exprs.s test/MC/AsmParser/paren.s

Jim Grosbach grosbach at apple.com
Wed Feb 23 11:33:53 PST 2011


On Feb 23, 2011, at 10:54 AM, Joerg Sonnenberger wrote:

> On Wed, Feb 23, 2011 at 10:10:54AM -0800, Jim Grosbach wrote:
>> Ping. Any progress on fixing this? It needs to be either fixed or reverted.
> 
> This doesn't break valid code. Reverting it does. You haven't really
> made a proper suggestion for how to handle [] on other platforms either.
> I don't exactly get the argument about ARM, but llvm-mc doesn't seem to
> deal with any of the NetBSD ARM assembler files. So I guess there are
> bigger fishes to fry...
> 

You don't seem to understand. Disregarding concerns like this is not acceptable. Conditionalizing the behavior properly is a problem for you to solve since you're the one who wants the changes.

I reiterate. Either fix it or revert it.

-Jim





More information about the llvm-commits mailing list