[llvm-commits] [llvm] r125595 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/exprs.s test/MC/AsmParser/paren.s

Jim Grosbach grosbach at apple.com
Mon Feb 21 16:43:34 PST 2011


On Feb 16, 2011, at 4:08 PM, Joerg Sonnenberger wrote:
> 
>> Joerg, how common are assembly files with [] in them? If common, can you 
>> code a patch making [] conditional on x86(-64) ELF?
> 
> Why not just make the function virtual and let platforms that can't
> accept the default behavior overwrite it? I actually think that quite a
> few platforms GNU as support don't distinguish between [] and () as the
> patch implements.

That's mandating opt-out from all targets that don't want the behavior, which is the opposite of how this sort of thing should be. The default behaviour should be those bits that all targets want. If there's additional stuff necessary for a target, that logic should be specific for the targets that want it.

-Jim



More information about the llvm-commits mailing list