[llvm-commits] [PATCH] Patch (WIP) to custom-lower 64-bit relational comparisons on x86-32

[Chris Lattner]

On Feb 19, 2011, at 2:34 PM, Eli Friedman wrote:

>> 
>> This looks pretty spiffy to me.  A couple of requests though:
>> 
>> 1. Please make this work for i128 on x86-64.
>> 2. Please change the if/else sequence to use a switch with a  default case that explodes.
>> 4. Please fit in 80 columns
>> 8. I think you only need to do the setOperationAction when building for 32-bit.
>> 16. Does the code handle weird conditions like "COND_P"?
> 
> COND_P can't show up here.
> 
> Updated patch attached; I think this is close to commit-quality.

Looks good to me, I'd appreciate if it the dagcombine fixme could be addressed in a subsequent patch though.

-Chris