[llvm-commits] [Review Request] lib/MC/WinCOFFStreamer.cpp: [PR8354] Emit .bss as .bss${foobar} instead of .bss$linkonce_{foobar} and emit local storage without IMAGE_SCN_LNK_COMDAT.

NAKAMURA Takumi geek4civic at gmail.com
Fri Feb 18 04:34:38 PST 2011


---
 lib/MC/WinCOFFStreamer.cpp |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
---

I had used the patch in bugs.
http://llvm.org/bugs/show_bug.cgi?id=8354#c2

It is improved version. WinCOFFStreamer::AddCommonSymbol() can emit
symbols's alignment as section alignment, though, .lcomm's alignment
is not emitted for now.

Now, each common symbols would be emitted as individual section .bss${foobar}.
It might be overkill. :p

Checked with 3-stage clang build on Windows x64.


...Takumi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-MC-WinCOFFStreamer.cpp-PR8354-Emit-.bss-as-..patch.txt
Type: text/x-patch
Size: 1132 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110218/e9c392e6/attachment.bin>


More information about the llvm-commits mailing list