[llvm-commits] [Review Request] lib/Target/X86/X86FastISel.cpp: [PR6275] Fix for Win32's dllimport function.

[NAKAMURA Takumi]

Function must not be GlobalVariable.

FIXME: Are latter conditions needed to check?
---
 lib/Target/X86/X86FastISel.cpp |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---

I am dubious in one point;

    // Can't handle TLS or DLLImport.
    // FIXME: Are they needed?
    if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GV))
      if (GVar->isThreadLocal() || GVar->hasDLLImportLinkage())
        return false;

Let me know if this clause could be eliminated, thank you.

...Takumi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-Target-X86-X86FastISel.cpp-PR6275-Fix-for-Wi.patch.txt
Type: text/x-patch
Size: 686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110218/afea6dda/attachment.bin>