[llvm-commits] [PATCH] Patch (WIP) to custom-lower 64-bit relational comparisons on x86-32
Chris Lattner
clattner at apple.com
Thu Feb 17 15:22:45 PST 2011
On Feb 16, 2011, at 4:25 PM, Eli Friedman wrote:
> I'm mainly looking for feedback as to whether this seems like
> generally a good idea... I haven't seen any compiler use this
> particular implementation of relational comparisons.
This looks pretty spiffy to me. A couple of requests though:
1. Please make this work for i128 on x86-64.
2. Please change the if/else sequence to use a switch with a default case that explodes.
4. Please fit in 80 columns
8. I think you only need to do the setOperationAction when building for 32-bit.
16. Does the code handle weird conditions like "COND_P"?
-Chris
More information about the llvm-commits
mailing list