[llvm-commits] [llvm] r125595 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/exprs.s test/MC/AsmParser/paren.s

[Joerg Sonnenberger]

On Tue, Feb 15, 2011 at 06:02:10PM -0800, Jim Grosbach wrote:
> Shouldn't something like this, at minimum, be predicated on a target
> enabling it? I doubt this is something all assembly variants want.

ParseBracketExpr can be made virtual if necessary, but the current
status quo breaks completely legal code on i386.

> For example, on x86 does Intel vs ATT syntax change whether this is
> supported? What about other targets? Do they want this enabled at all?
> Square brackets often have special meaning (memory references being
> the most common) and this could very easily complicate that.

AT&T syntax doesn't care about [], I think. Intel syntax is messy as best,
but if it could only need a virtual override.

Joerg