[llvm-commits] Patch for #9067

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Sun Feb 13 18:18:34 PST 2011


On 2011-02-13 07:43, pawel kunio wrote:
> I attached a fix to #9067. 
> 
> Brief description: references to symbols following stdcall naming
> convention 
> stringid@<sumsizeofparams> get confused by AsmParser with id at GOT 
> or id at PLT identifiers.  User gets rather mean "invalid variant" error
> and parser fails.

Please add a test and use the same style as the rest of the file:

if (foo) {
} else {
}

Are things like foo at PLT valid on windows too? I think we would still
accept it with this patch.

> Patch attached.

Cheers,
Rafael



More information about the llvm-commits mailing list