[llvm-commits] [Review request][Win64] Patches for Mingw-w64(and mingw64-clang)

[Eric Christopher]

On Feb 7, 2011, at 9:27 PM, NAKAMURA Takumi wrote:

> ---Part 1
> https://github.com/chapuni/LLVM/commits/mingw64/20110208/
> 
> NAKAMURA Takumi (5):
>  Windows/Program.inc: Eliminate the declaration of
>    SetInformationJobObject(). It should be provided with
>    _WIN32_WINNT>=0x0500.
>  Windows/DynamicLibrary.inc: ELM_Callback fix
>  autoconf: Seek strerror_s() with AC_CHECK_DECLS.
>  Regenerate configure. (**** unsent ***)
>  lib/Support/Errno.cpp: Check strerror_s() with HAVE_DECL_STRERROR_S
>    int config.h.*.
> 
> autoconf/configure.ac                  |    5 ++-
> cmake/config-ix.cmake                  |    2 +-
> configure                              |   90 +++++++++++++++++++++++++++++++-
> include/llvm/Config/config.h.cmake     |    7 ++-
> include/llvm/Config/config.h.in        |    7 ++-
> lib/Support/Errno.cpp                  |    2 +-
> lib/Support/Windows/DynamicLibrary.inc |   12 ++++-
> lib/Support/Windows/Program.inc        |    9 ---
> 8 files changed, 113 insertions(+), 21 deletions(-)
> 
> ---Part 2-1 (exclusive against part 2-2)
> https://github.com/chapuni/LLVM/commits/mingw64/20110208-1
> 
> NAKAMURA Takumi (1):
>  Windows/Windows.h: Redefine _WIN32_WINNT here. mingw-w64 tends to
>    define it as 0x0502 in its headers.
> 
> lib/Support/Windows/Windows.h |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
> 
> ---Part 2-2 (exclusive against part 2-1)
> https://github.com/chapuni/LLVM/commits/mingw64/20110208-2
> 
> 

These all looked ok, if not great.

> NAKAMURA Takumi (1):
>  lib/Support: Always include Windows/Windows.h!
> 
> lib/Support/DynamicLibrary.cpp |    4 ++++
> lib/Support/Host.cpp           |    4 ++++
> lib/Support/Memory.cpp         |    4 ++++
> lib/Support/Mutex.cpp          |    4 ++++
> lib/Support/Path.cpp           |    7 +++++++
> lib/Support/PathV2.cpp         |    4 ++++
> lib/Support/Process.cpp        |    4 ++++
> lib/Support/Program.cpp        |    4 ++++
> lib/Support/RWMutex.cpp        |    4 ++++
> lib/Support/Signals.cpp        |    4 ++++
> lib/Support/ThreadLocal.cpp    |    4 ++++
> lib/Support/TimeValue.cpp      |    4 ++++
> lib/Support/Windows/Windows.h  |    5 +++++
> 13 files changed, 56 insertions(+), 0 deletions(-)

I responded to this one, but we can keep it here too. "Uh, eew?"

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110208/928e452e/attachment.html>