[llvm-commits] [PATCH] s/CORTEX-A8/cortex-a8/ in ARMAsmPrinter.cpp

[Jason Kim]

On Mon, Feb 7, 2011 at 6:46 AM, Edmund Grimley-Evans
<Edmund.Grimley-Evans at arm.com> wrote:
> The CodeSourcery toolchain from about a year ago needs lower case in this line in the assembler file:
>
>        .cpu cortex-a8
>
> So this patch might be a good idea, unless some other tool version requires upper case:
>

Thanks for noticing this.

Gosh darn it, at least one version likes upper case in the
.ARM.attributes. for ELF.o
I guess we can put in lower case in .s, and upper case in .o?

>
> Index: lib/Target/ARM/ARMAsmPrinter.cpp
> ===================================================================
> --- lib/Target/ARM/ARMAsmPrinter.cpp    (revision 125005)
> +++ lib/Target/ARM/ARMAsmPrinter.cpp    (working copy)
> @@ -467,7 +467,7 @@
>
>   if (CPUString == "cortex-a8" ||
>       Subtarget->isCortexA8()) {
> -    AttrEmitter->EmitTextAttribute(ARMBuildAttrs::CPU_name, "CORTEX-A8");
> +    AttrEmitter->EmitTextAttribute(ARMBuildAttrs::CPU_name, "cortex-a8");
>     AttrEmitter->EmitAttribute(ARMBuildAttrs::CPU_arch, ARMBuildAttrs::v7);
>     AttrEmitter->EmitAttribute(ARMBuildAttrs::CPU_arch_profile,
>                                ARMBuildAttrs::ApplicationProfile);
> --
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>