[llvm-commits] _WIN32_WINNT as predefined (was Re: [Review request][Win64] Patches for Mingw-w64(and mingw64-clang))

[NAKAMURA Takumi]

Eric, thanks to give me comments.

2011/2/7 Eric Christopher <echristo at apple.com>:
> I don't like that way of doing it necessarily either, though it's not any worse than having a windows only include. Is there some reason why you'd need to have all of those defines in every file that includes config.h as opposed to just doing some work in libSupport as Anton suggests?

I would like to let configure predefined macros recognized, to work
with AC_CHECK_DECL.
I thought it might be smarter, though, I have got two objections ;)

I would suggest to use AC_GNU_SOURCE, too.
(It also inserts _GNU_SOURCE to config.h.in.)

I will rewrite my patches w/o modifying autoconf's style, later.


>> May I reopen PR7809 - TargetSelect.h shouldn't include llvm/Config/config.h ?
>> http://llvm.org/bugs/show_bug.cgi?id=7809
>> In TOT, a few headers depend on llvm/Config/config.h.

> No, don't reopen that bug. It isn't related as far as I know unless it's a public header including config.h.

Excuse me, it was not related directly to this article.
On TOT, I saw a few dependencies to config.h. Is there no issue?

../install-llvm/include/clang/Basic/FileManager.h
../install-llvm/include/llvm/Support/Endian.h
../install-llvm/include/llvm/Support/system_error.h
../install-llvm/include/llvm/Support/FEnv.h


...Takumi